Add a new "finished" field, which is used so that KVO notifcations for isFinishe…

…d are only sent at the point when finished is actually changed.

Also only send notifications for isExecuting if it has changed state. (markAsFinished can be called more than once for cancelled requests)

@@ -153,6 +153,9 @@ extern unsigned long const ASIWWANBandwidthThrottleAmount;
 	// When the request fails or completes successfully, complete will be true
 	// When the request fails or completes successfully, complete will be true
 	BOOL complete;
 	BOOL complete;
 	
 	
+    // external "finished" indicator, subject of KVO notifications; updates after 'complete'
+    BOOL finished;
+    
 	// If an error occurs, error will contain an NSError
 	// If an error occurs, error will contain an NSError
 	// If error code is = ASIConnectionFailureErrorType (1, Connection failure occurred) - inspect [[error userInfo] objectForKey:NSUnderlyingErrorKey] for more information
 	// If error code is = ASIConnectionFailureErrorType (1, Connection failure occurred) - inspect [[error userInfo] objectForKey:NSUnderlyingErrorKey] for more information
 	NSError *error;
 	NSError *error;

@@ -604,7 +604,7 @@ static NSOperationQueue *sharedQueue = nil;
 
 
 - (BOOL)isFinished 
 - (BOOL)isFinished 
 {
 {
-	return [self complete];
+	return finished;
 }
 }
 
 
 - (BOOL)isExecuting {
 - (BOOL)isExecuting {
@@ -2822,12 +2822,21 @@ static NSOperationQueue *sharedQueue = nil;
 		CFMakeCollectable(proxyAuthentication);
 		CFMakeCollectable(proxyAuthentication);
 	}
 	}
 
 
+    BOOL wasInProgress = inProgress;
+    BOOL wasFinished = finished;
+
+    if (!wasFinished)
         [self willChangeValueForKey:@"isFinished"];
         [self willChangeValueForKey:@"isFinished"];
+    if (wasInProgress)
         [self willChangeValueForKey:@"isExecuting"];
         [self willChangeValueForKey:@"isExecuting"];
+
 	[self setInProgress:NO];
 	[self setInProgress:NO];
 	[self setStatusTimer:nil];
 	[self setStatusTimer:nil];
+    finished = YES;
 
 
+    if (wasInProgress)
         [self didChangeValueForKey:@"isExecuting"];
         [self didChangeValueForKey:@"isExecuting"];
+    if (!wasFinished)
         [self didChangeValueForKey:@"isFinished"];
         [self didChangeValueForKey:@"isFinished"];
 
 
 	CFRunLoopStop(CFRunLoopGetCurrent());
 	CFRunLoopStop(CFRunLoopGetCurrent());