Ben Copsey

Fix URLs in tests

Close postBodyReadStream when request is complete
... ... @@ -583,6 +583,8 @@ static NSError *ASITooMuchRedirectionError;
readStream = NULL;
}
[[self postBodyReadStream] close];
if (rawResponseData) {
[self setRawResponseData:nil];
... ... @@ -1027,8 +1029,6 @@ static NSError *ASITooMuchRedirectionError;
[self setRequestMethod:@"GET"];
[self setPostBody:nil];
[self setPostLength:0];
[self setPostBodyFilePath:nil];
[self setPostBodyWriteStream:nil];
[self setRequestHeaders:nil];
}
[self setURL:[[NSURL URLWithString:[responseHeaders valueForKey:@"Location"] relativeToURL:[self url]] absoluteURL]];
... ... @@ -1356,6 +1356,8 @@ static NSError *ASITooMuchRedirectionError;
readStream = NULL;
}
[[self postBodyReadStream] close];
NSError *fileError = nil;
// Delete up the request body temporary file, if it exists
... ...
... ... @@ -670,11 +670,11 @@
// Ensure request method changes to get
- (void)test303Redirect
{
ASIHTTPRequest *request = [ASIHTTPRequest requestWithURL:[NSURL URLWithString:@"http://asi/ASIHTTPRequest/tests/redirect_303"]];
ASIHTTPRequest *request = [ASIHTTPRequest requestWithURL:[NSURL URLWithString:@"http://allseeing-i.com/ASIHTTPRequest/tests/redirect_303"]];
[request setRequestMethod:@"PUT"];
[request appendPostData:[@"Fuzzy" dataUsingEncoding:NSUTF8StringEncoding]];
[request start];
BOOL success = [[[request url] absoluteString] isEqualToString:@"http://asi/ASIHTTPRequest/tests/request-method"];
BOOL success = [[[request url] absoluteString] isEqualToString:@"http://allseeing-i.com/ASIHTTPRequest/tests/request-method"];
GHAssertTrue(success,@"Failed to redirect to correct location");
success = [[request responseString] isEqualToString:@"GET"];
GHAssertTrue(success,@"Failed to use GET on new URL");
... ...