Toggle navigation
Toggle navigation
This project
Loading...
Sign in
iOS
/
asi-http-request
Go to a project
Toggle navigation
Toggle navigation pinning
Projects
Groups
Snippets
Help
Project
Activity
Repository
Pipelines
Graphs
Issues
0
Merge Requests
0
Wiki
Network
Create a new issue
Builds
Commits
Authored by
Ben Copsey
2009-03-22 18:14:22 +0000
Browse Files
Options
Browse Files
Download
Email Patches
Plain Diff
Commit
05ffabc47512aa55c2bd1692340bfb4cf528f916
05ffabc4
1 parent
83393425
Fix cookies values being re-encoded
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
4 deletions
Classes/ASIHTTPRequest.m
Classes/Tests/ASIHTTPRequestTests.m
Classes/ASIHTTPRequest.m
View file @
05ffabc
...
...
@@ -830,18 +830,25 @@ static NSError *ASIUnableToCreateRequestError;
// Handle cookies
NSArray
*
cookies
=
[
NSHTTPCookie
cookiesWithResponseHeaderFields
:
responseHeaders
forURL
:
url
];
[
self
setResponseCookies
:
cookies
];
NSMutableArray
*
newCookies
=
[[[
NSMutableArray
alloc
]
init
]
autorelease
];
for
(
NSHTTPCookie
*
cookie
in
cookies
)
{
NSMutableDictionary
*
properties
=
[[[
NSMutableDictionary
alloc
]
initWithDictionary
:[
cookie
properties
]]
autorelease
];
[
properties
setValue
:[
cookie
decodedValue
]
forKey
:
NSHTTPCookieValue
];
[
newCookies
addObject
:[
NSHTTPCookie
cookieWithProperties
:
properties
]];
}
[
self
setResponseCookies
:
newCookies
];
if
(
useCookiePersistance
)
{
// Store cookies in global persistent store
[[
NSHTTPCookieStorage
sharedHTTPCookieStorage
]
setCookies
:
c
ookies
forURL
:
url
mainDocumentURL
:
nil
];
[[
NSHTTPCookieStorage
sharedHTTPCookieStorage
]
setCookies
:
newC
ookies
forURL
:
url
mainDocumentURL
:
nil
];
// We also keep any cookies in the sessionCookies array, so that we have a reference to them if we need to remove them later
if
(
!
sessionCookies
)
{
[
ASIHTTPRequest
setSessionCookies
:[[[
NSMutableArray
alloc
]
init
]
autorelease
]];
NSHTTPCookie
*
cookie
;
for
(
cookie
in
c
ookies
)
{
for
(
cookie
in
newC
ookies
)
{
[[
ASIHTTPRequest
sessionCookies
]
addObject
:
cookie
];
}
}
...
...
Classes/Tests/ASIHTTPRequestTests.m
View file @
05ffabc
...
...
@@ -302,7 +302,6 @@
success
=
[
html
isEqualToString
:
@"I have 'Test Value' as the value of 'ASIHTTPRequestTestCookie'"
];
GHAssertTrue
(
success
,
@"Custom cookie not presented to the server with cookie persistance OFF"
);
// Test removing all cookies works
[
ASIHTTPRequest
clearSession
];
...
...
@@ -534,4 +533,5 @@
GHAssertTrue
(
success
,
@"Failed to correctly display increment progress for a partial download"
);
}
@end
...
...
Please
register
or
login
to post a comment