Toggle navigation
Toggle navigation
This project
Loading...
Sign in
iOS
/
asi-http-request
Go to a project
Toggle navigation
Toggle navigation pinning
Projects
Groups
Snippets
Help
Project
Activity
Repository
Pipelines
Graphs
Issues
0
Merge Requests
0
Wiki
Network
Create a new issue
Builds
Commits
Authored by
Ben Copsey
2010-05-01 11:54:25 +0100
Browse Files
Options
Browse Files
Download
Email Patches
Plain Diff
Commit
74a108cf938aa7623e205fabddf74805d7e87386
74a108cf
1 parent
6df44043
Fix problem where queue delegate would not be alerted when the request received response headers
Add test for same
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
3 deletions
Classes/ASIHTTPRequest.m
Classes/ASINetworkQueue.m
Classes/Tests/ASINetworkQueueTests.h
Classes/Tests/ASINetworkQueueTests.m
Classes/ASIHTTPRequest.m
View file @
74a108c
...
...
@@ -23,7 +23,7 @@
// Automatically set on build
NSString
*
ASIHTTPRequestVersion
=
@"v1.6.2-
4 2010-04-19
"
;
NSString
*
ASIHTTPRequestVersion
=
@"v1.6.2-
7 2010-05-01
"
;
NSString
*
const
NetworkRequestErrorDomain
=
@"ASIHTTPRequestErrorDomain"
;
...
...
Classes/ASINetworkQueue.m
View file @
74a108c
...
...
@@ -201,7 +201,7 @@
}
}
-
(
void
)
request
DidReceive
ResponseHeaders
:
(
ASIHTTPRequest
*
)
request
-
(
void
)
request
Received
ResponseHeaders
:
(
ASIHTTPRequest
*
)
request
{
if
([
self
requestDidReceiveResponseHeadersSelector
])
{
[[
self
delegate
]
performSelector
:[
self
requestDidReceiveResponseHeadersSelector
]
withObject
:
request
];
...
...
Classes/Tests/ASINetworkQueueTests.h
View file @
74a108c
...
...
@@ -48,6 +48,7 @@ IMPORTANT
BOOL
finished
;
BOOL
failed
;
BOOL
headFailed
;
BOOL
receivedResponseHeaders
;
int
queueFinishedCallCount
;
}
...
...
Classes/Tests/ASINetworkQueueTests.m
View file @
74a108c
...
...
@@ -63,6 +63,7 @@ IMPORTANT
[
networkQueue
setDelegate
:
self
];
[
networkQueue
setRequestDidStartSelector
:
@selector
(
delegateTestStarted
:)];
[
networkQueue
setRequestDidFinishSelector
:
@selector
(
delegateTestFinished
:)];
[
networkQueue
setRequestDidReceiveResponseHeadersSelector
:
@selector
(
delegateTestResponseHeaders
:)];
ASIHTTPRequest
*
request
=
[
ASIHTTPRequest
requestWithURL
:[
NSURL
URLWithString
:
@"http://allseeing-i.com"
]];
[
networkQueue
addOperation
:
request
];
...
...
@@ -70,7 +71,10 @@ IMPORTANT
[
networkQueue
waitUntilAllOperationsAreFinished
];
GHAssertTrue
(
started
,
@"Failed to call the delegate method when the request started"
);
[[
NSRunLoop
currentRunLoop
]
runUntilDate
:[
NSDate
dateWithTimeIntervalSinceNow
:
2
]];
GHAssertTrue
(
started
,
@"Failed to call the delegate method when the request started"
);
GHAssertTrue
(
receivedResponseHeaders
,
@"Failed to call the delegate method when the request received response headers"
);
GHAssertTrue
(
finished
,
@"Failed to call the delegate method when the request finished"
);
networkQueue
=
[
ASINetworkQueue
queue
];
...
...
@@ -83,6 +87,8 @@ IMPORTANT
[
networkQueue
go
];
[
networkQueue
waitUntilAllOperationsAreFinished
];
[[
NSRunLoop
currentRunLoop
]
runUntilDate
:[
NSDate
dateWithTimeIntervalSinceNow
:
2
]];
GHAssertTrue
(
failed
,
@"Failed to call the delegate method when the request failed"
);
...
...
@@ -93,6 +99,12 @@ IMPORTANT
started
=
YES
;
}
-
(
void
)
delegateTestResponseHeaders
:
(
ASIHTTPRequest
*
)
request
{
GHAssertNotNil
([
request
responseHeaders
],
@"Called delegateTestResponseHeaders: when we have no headers"
);
receivedResponseHeaders
=
YES
;
}
-
(
void
)
delegateTestFinished
:
(
ASIHTTPRequest
*
)
request
{
finished
=
YES
;
...
...
Please
register
or
login
to post a comment