Ben Copsey

Tweaks

@@ -683,8 +683,8 @@ static NSError *ASIUnableToCreateRequestError; @@ -683,8 +683,8 @@ static NSError *ASIUnableToCreateRequestError;
683 return; 683 return;
684 } 684 }
685 685
686 - // If this is the first time we've written to the buffer, byteCount will be the size of the buffer (currently seems to be 128KB on both Mac and iPhone) 686 + // If this is the first time we've written to the buffer, byteCount will be the size of the buffer (currently seems to be 128KB on both Mac and iPhone 2.2.1, 32KB on iPhone 3.0)
687 - // If request body is less than 128KB, byteCount will be the total size of the request body 687 + // If request body is less than the buffer size, byteCount will be the total size of the request body
688 // We will remove this from any progress display, as kCFStreamPropertyHTTPRequestBytesWrittenCount does not tell us how much data has actually be written 688 // We will remove this from any progress display, as kCFStreamPropertyHTTPRequestBytesWrittenCount does not tell us how much data has actually be written
689 if (totalBytesSent > 0 && uploadBufferSize == 0 && totalBytesSent != postLength) { 689 if (totalBytesSent > 0 && uploadBufferSize == 0 && totalBytesSent != postLength) {
690 [self setUploadBufferSize:totalBytesSent]; 690 [self setUploadBufferSize:totalBytesSent];
@@ -15,7 +15,7 @@ extern NSString *const ASIS3AccessPolicyPrivate; // This is the default in S3 wh @@ -15,7 +15,7 @@ extern NSString *const ASIS3AccessPolicyPrivate; // This is the default in S3 wh
15 extern NSString *const ASIS3AccessPolicyPublicRead; 15 extern NSString *const ASIS3AccessPolicyPublicRead;
16 extern NSString *const ASIS3AccessPolicyPublicReadWrote; 16 extern NSString *const ASIS3AccessPolicyPublicReadWrote;
17 extern NSString *const ASIS3AccessPolicyAuthenticatedRead; 17 extern NSString *const ASIS3AccessPolicyAuthenticatedRead;
18 - 18 +bug report in lighthouse
19 @interface ASIS3Request : ASIHTTPRequest { 19 @interface ASIS3Request : ASIHTTPRequest {
20 20
21 // Your S3 access key. Set it on the request, or set it globally using [ASIS3Request setSharedAccessKey:] 21 // Your S3 access key. Set it on the request, or set it globally using [ASIS3Request setSharedAccessKey:]
@@ -27,7 +27,7 @@ extern NSString *const ASIS3AccessPolicyAuthenticatedRead; @@ -27,7 +27,7 @@ extern NSString *const ASIS3AccessPolicyAuthenticatedRead;
27 // Name of the bucket to talk to 27 // Name of the bucket to talk to
28 NSString *bucket; 28 NSString *bucket;
29 29
30 - // path to the resource you want to access on S3. Leave empty for the bucket root 30 + // Path to the resource you want to access on S3. Leave empty for the bucket root
31 NSString *path; 31 NSString *path;
32 32
33 // The string that will be used in the HTTP date header. Generally you'll want to ignore this and let the class add the current date for you, but the accessor is used by the tests 33 // The string that will be used in the HTTP date header. Generally you'll want to ignore this and let the class add the current date for you, but the accessor is used by the tests
@@ -113,7 +113,6 @@ static NSString *sharedSecretAccessKey = nil; @@ -113,7 +113,6 @@ static NSString *sharedSecretAccessKey = nil;
113 [self setPath:@""]; 113 [self setPath:@""];
114 } 114 }
115 115
116 -  
117 NSString *canonicalizedResource = [NSString stringWithFormat:@"/%@/%@",[self bucket],[self path]]; 116 NSString *canonicalizedResource = [NSString stringWithFormat:@"/%@/%@",[self bucket],[self path]];
118 117
119 // Add a header for the access policy if one was set, otherwise we won't add one (and S3 will default to private) 118 // Add a header for the access policy if one was set, otherwise we won't add one (and S3 will default to private)