Toggle navigation
Toggle navigation
This project
Loading...
Sign in
iOS
/
asi-http-request
Go to a project
Toggle navigation
Toggle navigation pinning
Projects
Groups
Snippets
Help
Project
Activity
Repository
Pipelines
Graphs
Issues
0
Merge Requests
0
Wiki
Network
Create a new issue
Builds
Commits
Authored by
Ben Copsey
2009-10-14 11:07:01 +0100
Browse Files
Options
Browse Files
Download
Email Patches
Plain Diff
Commit
b93b4e107c52d7d9b55c622addb6c56e8ab4486e
b93b4e10
1 parent
d310696c
Stop resetting request method to POST when an unrecognised method is already set
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
1 deletions
Classes/ASIHTTPRequest.m
Classes/Tests/ASIHTTPRequestTests.m
Classes/ASIHTTPRequest.m
View file @
b93b4e1
...
...
@@ -295,7 +295,7 @@ static NSOperationQueue *sharedRequestQueue = nil;
}
if
([
self
postLength
]
>
0
)
{
if
(
!
[
requestMethod
isEqualToString
:
@"POST"
]
&&
!
[
requestMethod
isEqualToString
:
@"PUT
"
])
{
if
(
[
requestMethod
isEqualToString
:
@"GET"
]
||
[
requestMethod
isEqualToString
:
@"DELETE"
]
||
[
requestMethod
isEqualToString
:
@"HEAD
"
])
{
[
self
setRequestMethod
:
@"POST"
];
}
[
self
addRequestHeader
:
@"Content-Length"
value
:[
NSString
stringWithFormat
:
@"%llu"
,[
self
postLength
]]];
...
...
Classes/Tests/ASIHTTPRequestTests.m
View file @
b93b4e1
...
...
@@ -125,6 +125,14 @@
BOOL
success
=
[[
request
responseString
]
isEqualToString
:
method
];
GHAssertTrue
(
success
,
@"Failed to set the request method correctly"
);
}
// Test to ensure we don't change the request method when we have an unrecognised method already set
ASIHTTPRequest
*
request
=
[[[
ASIHTTPRequest
alloc
]
initWithURL
:
url
]
autorelease
];
[
request
setRequestMethod
:
@"FINK"
];
[
request
appendPostData
:[
@"King"
dataUsingEncoding
:
NSUTF8StringEncoding
]];
[
request
buildPostBody
];
BOOL
success
=
[[
request
requestMethod
]
isEqualToString
:
@"FINK"
];
GHAssertTrue
(
success
,
@"Erroneously changed request method"
);
}
-
(
void
)
testHTTPVersion
...
...
Please
register
or
login
to post a comment