Tweak user agent generation to be smart about the version numbers used
Showing
1 changed file
with
15 additions
and
3 deletions
@@ -2465,9 +2465,21 @@ static NSRecursiveLock *delegateAuthenticationLock = nil; | @@ -2465,9 +2465,21 @@ static NSRecursiveLock *delegateAuthenticationLock = nil; | ||
2465 | if (!appName) { | 2465 | if (!appName) { |
2466 | return nil; | 2466 | return nil; |
2467 | } | 2467 | } |
2468 | - NSString *appVersion = [[bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"] stringByAppendingFormat:@" (%@)", | 2468 | + NSString *appVersion = nil; |
2469 | - [bundle objectForInfoDictionaryKey:@"CFBundleVersion"]]; | 2469 | + NSString *marketingVersionNumber = [bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"]; |
2470 | - NSString *deviceName;; | 2470 | + NSString *developmentVersionNumber = [bundle objectForInfoDictionaryKey:@"CFBundleVersion"]; |
2471 | + if (marketingVersionNumber && developmentVersionNumber) { | ||
2472 | + if ([marketingVersionNumber isEqualToString:developmentVersionNumber]) { | ||
2473 | + appVersion = marketingVersionNumber; | ||
2474 | + } else { | ||
2475 | + appVersion = [NSString stringWithFormat:@"%@ rv:%@",marketingVersionNumber,developmentVersionNumber]; | ||
2476 | + } | ||
2477 | + } else { | ||
2478 | + appVersion = (marketingVersionNumber ? marketingVersionNumber : developmentVersionNumber); | ||
2479 | + } | ||
2480 | + | ||
2481 | + | ||
2482 | + NSString *deviceName; | ||
2471 | NSString *OSName; | 2483 | NSString *OSName; |
2472 | NSString *OSVersion; | 2484 | NSString *OSVersion; |
2473 | 2485 |
-
Please register or login to post a comment