iOS / asi-http-request

Fix warnings when compiling with some -W options.

(-Wno-implicit-atomic-properties).

signedness of an integer value (-Wsign-conversion).

Fix iOS 7 warnings for dismissModalViewControllerAnimated and presentModalViewController

…lerAnimated:completion: etc

Restored compatibility with OS X 10.5

Updated deprecated method addTimeInterval

addTimeInterval changed to dateByAddingTimeInterval

Error is: ASIHTTPRequest.m:4571:44: Division by zero

I think this may be a false warning, or llvm is assuming that "[bandwidthUsageTracker addObject:...];" has failed for some reason, but it does no harm to double check that we're not going to divide by zero.

It seems the comparison has always been against the wrong enum, so the check would never trigger previously.

The latest llvm issues a warning like this:
ASIDataDecompressor.m:161:34: Comparison of constant 'NSStreamEventErrorOccurred' (8) with expression of type 'NSStreamStatus' (aka 'enum NSStreamStatus') is always false

[patch from github user 'OpenFibers', thanks!]

Conflicts (already fixed so discarded these):
	Classes/ASIDataCompressor.m
	Classes/ASIDataDecompressor.m
(and changed ASIS3BucketRequest.m to avoid the need to cast)

Minor fixes for warnings reported by static analyzer

Update the test case due to the userAgent to userAgentString change.

#309

Rename userAgent -> userAgentString

Apparently Apple doesn't like it when asi-http synthesizes userAgent.

https://github.com/pokeb/asi-http-request/issues/309

Clean up the use of CFRunLoop.

Identical patches submitted by both Carson Reinke & yllan - thanks!

Fixed bug preventing ASIAuthenticationDialog from being dismissed on iOS5

Fixes dictionary memory leak when certificate checking is disabled. Refs #263.

Problem was introduced in commit:66003748.

In iOS 5, the ASIAuthenticationDialog could not be dismissed using either the Cancel button or automatically by successfully logging in.
The bug is due to a change in UIViewController in iOS 5.  The class & instance "dismiss" methods are using [UIViewController parentViewController] which, as of iOS 5, no longer returns the presenting view controller.  A new property called 'presentingViewController' was added in iOS 5 to make up for this.

Changed the class & instance dismiss methods to use the "presentingViewController" property if it is available (iOS 5+).  If not, it falls back to the "parentViewController" property.

A dictionary is allocated and never released. Problem was
introduced in commit:66003748.

Previously, tasks running from inside the CFRunLoop would call CFRunLoopStop prior to finishing execution. This results in non-deterministic failures to call endBackgroundTask when running iOS tasks in the background with beginBackgroundTaskWithExpirationHandler.
Since the only reason to break out of the CFRunLoop is to flush the autorelease pool, we instead invoke CFRunLoopRunInMode with returnAfterSourceHandled=True, which safely returns and flushes the autorelease pool after each invocation of the CFRunLoop.

Patched issue #263 (if needed)

ASIFormDataRequest has a default 'GET' method (should be 'POST' by
default)

issue #263 - proposed patch

* Ensures external resource requests are properly removed from the queue and released when they fail
* Changes behaviour so that by default, external resource request failures do not cause everything else to fail

Also added new shouldIgnoreExternalResourceErrors property to control this

closes gh-253

Conflicts:
	Classes/ASIHTTPRequest.m

Fixed a typo + libxml is hidden from ASIWebPageRequest header

Small fix to remove C++ compile errors.