iOS / asi-http-request

#309

Rename userAgent -> userAgentString

Apparently Apple doesn't like it when asi-http synthesizes userAgent.

https://github.com/pokeb/asi-http-request/issues/309

Clean up the use of CFRunLoop.

Identical patches submitted by both Carson Reinke & yllan - thanks!

Fixed bug preventing ASIAuthenticationDialog from being dismissed on iOS5

Fixes dictionary memory leak when certificate checking is disabled. Refs #263.

Problem was introduced in commit:66003748.

In iOS 5, the ASIAuthenticationDialog could not be dismissed using either the Cancel button or automatically by successfully logging in.
The bug is due to a change in UIViewController in iOS 5.  The class & instance "dismiss" methods are using [UIViewController parentViewController] which, as of iOS 5, no longer returns the presenting view controller.  A new property called 'presentingViewController' was added in iOS 5 to make up for this.

Changed the class & instance dismiss methods to use the "presentingViewController" property if it is available (iOS 5+).  If not, it falls back to the "parentViewController" property.

A dictionary is allocated and never released. Problem was
introduced in commit:66003748.

Previously, tasks running from inside the CFRunLoop would call CFRunLoopStop prior to finishing execution. This results in non-deterministic failures to call endBackgroundTask when running iOS tasks in the background with beginBackgroundTaskWithExpirationHandler.
Since the only reason to break out of the CFRunLoop is to flush the autorelease pool, we instead invoke CFRunLoopRunInMode with returnAfterSourceHandled=True, which safely returns and flushes the autorelease pool after each invocation of the CFRunLoop.

Patched issue #263 (if needed)

ASIFormDataRequest has a default 'GET' method (should be 'POST' by
default)

issue #263 - proposed patch

* Ensures external resource requests are properly removed from the queue and released when they fail
* Changes behaviour so that by default, external resource request failures do not cause everything else to fail

Also added new shouldIgnoreExternalResourceErrors property to control this

closes gh-253

Conflicts:
	Classes/ASIHTTPRequest.m

Fixed a typo + libxml is hidden from ASIWebPageRequest header

Small fix to remove C++ compile errors.

Format string fixes and memory leak fixes.

bandwith / bandwidth issue

see ASIHTTPRequestConfig.h for additional information

when compiling with objective-c++.

CopyWithZone did not copy authenticationScheme

Conflicts:
	Classes/ASIHTTPRequest.m

…ages with a .html extension
This will help users that need to cache HTML content for display in a webview
closes gh-241

Small fix to the bandwidth throttler.

incorrectly charging the entire buffer size against the throttler
rather than just the number of bytes actually read.

For example, if you did a read with a 32KB buffer which only received
300 bytes across the wire, the bandwidth Throttler would charge
you for a full 32KB of bandwidth rather than the 300 bytes that
were really used.  This was grossly overstating the bandwidth
consumption to the throttler.

The CopyWithZone method did not copy the authenticationScheme, resulting
in problems when using a copied ASIHTTPRequest.